⚡ Bolt: [performance improvement] Hoist CSS and SHA-256 generation out of process_dir - #198
⚡ Bolt: [performance improvement] Hoist CSS and SHA-256 generation out of process_dir#198seonghobae wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headaeaa9c29e50cd2734c035133fc881ecdd9ccee32. -
Head SHA:
aeaa9c29e50cd2734c035133fc881ecdd9ccee32 -
Workflow run: 30424193692
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
|
|
Closing as superseded by canonical #363. The same hoisted stylesheet/hash work is implemented there along with exact CSP source-byte matching, independent generated-output verification, APA 7 doctoring, changelog, and fresh current-head CI/JaCoCo/security evidence. Expected-but-unmeasured runtime claims are not retained. No evidence is reused. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
💡 What: Hoisted static CSP style strings (
cssContent,css) and expensive cryptographicSHA-256hash generation out of the recursiveprocess_dirfunction, declaring them as top-levelprivate valproperties.🎯 Why:
process_diris called for every single directory traversed. Re-allocating the large CSS string and re-computing theSHA-256hash dynamically on every recursive call created severe, unnecessary CPU and memory overhead during tree generation.📊 Impact: Expected to reduce tree generation CPU time and memory allocation significantly on directories with many subdirectories, as string allocation and cryptographic hashing now only happen once at class load time rather than N times.
🔬 Measurement: Verify tests run properly and memory usage/GC pressure is reduced when running
html4treeon large directories (e.g. root file systems).PR created automatically by Jules for task 2433005278948987050 started by @seonghobae